Design Warnings


Visual Studio Team System
Do not declare protected members in sealed types

TypeName

DoNotDeclareProtectedMembersInSealedTypes

CheckId

CA1047

Category

Microsoft.Design

Breaking Change

Non Breaking

Cause

A public type is sealed (NotInheritable in Visual basic) and declares a protected member or a protected nested type. This rule does not report violations for Finalize methods, which must follow this pattern.

Rule Description

Types declare protected members so that inheriting types can access or override the member. By definition, you cannot inherit from a sealed type, which means that protected methods on sealed types cannot be called.

The C# compiler issues a warning for this error.

How to Fix Violations

To fix a violation of this rule, change the access level of the member to private, or make the type inheritable.

When to Suppress Warnings

Do not suppress a warning from this rule. Leaving the type in its current state can cause maintenance issues and does not provide any benefits.

Example

The following example shows a type that violates this rule.

Visual Basic
Imports System

Namespace DesignLibrary

   Public NotInheritable Class BadSealedType
      Protected  Sub MyMethod
      End Sub
   End Class

End Namespace
C#
using System;

namespace DesignLibrary
{
   public sealed class SealedClass
   {
      protected void ProtectedMethod(){}
   }
}

The above sealed type declares a protected member, which cannot be called outside the class that declares it.

If the method was designed to be called by other types, increase its accessibility to public, otherwise, reduce its accessibility to private.

The following example fixes the above violation by increasing the method's accessibility to public.

Visual Basic
Imports System

Namespace Samples

   Public NotInheritable Class Book
        Protected Sub Read      
    End Sub

   End Class

End Namespace
C#
using System;

namespace Samples
{    
    public sealed class Book     
    {        
        protected void Read()        
        {        
        }    
    }
}
Tags :


Community Content

AndyDragon_ca
As of v1.35, fxcop DOES fire for sealed classes with protected overrides from base classes in c#:
class Foo
{
    protected virtual void DoSomething()
    {
    }
}
 
sealed class Bar : Foo
{
    protected override void DoSomething()
    {
        base.DoSomething();
    }
}

This will fire the event when building with fxcop 1.35, a suppression is required to not fire the violation.

Tags :

Shags199
Possible typo with the solution to fix described here?
Tags : contentbug

Shags199
Possible typo with the solution to fix described here?
Tags :

Shags199
Possible typo with the solution to fix described here?
Tags :

Shags199
Possible typo with the solution to fix described here?
Tags :

Page view tracker